Skip to content

Fix command to show linters #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix command to show linters #318

wants to merge 2 commits into from

Conversation

renatosuero
Copy link
Contributor

The current readme show the command:

$ golangci-lint help linters

but it doesn't work, the correct is

$ golangci-lint linters help

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2018

CLA assistant check
All committers have signed the CLA.

@renatosuero
Copy link
Contributor Author

renatosuero commented Dec 18, 2018

I don't know why the build fails, I only changed help linters to linters help. Can someone help me?

@alexkohler
Copy link

alexkohler commented Dec 18, 2018

@renatosuero You can view the console logs by clicking on the job for this PR and then selecting the go1.10/1.11 job. It looks like the following make command is failing:

make: *** [check_generated] Error 1
The command "make check_generated test" exited with 2.

@renatosuero
Copy link
Contributor Author

thanks, @alexkohler, I checked the log, but I run the commands in my computer and I have no errors :(

@jirfag jirfag closed this in 21c2590 Dec 22, 2018
@jirfag
Copy link
Contributor

jirfag commented Dec 22, 2018

Hi! I've made a better validation of command args in the linked commit.
We have the following commands:

  1. golangci-lint linters - it shows current linters configuration: which linters are enabled/disabled
  2. golangci-lint help linters - show information about all linters: which are enabled/disabled by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants